Re: [PR] [type:feat]Discovery adapts to namespace transformation [shenyu]

[via GitHub]

ywj1352 commented on code in PR #5655:
URL: https://github.com/apache/shenyu/pull/5655#discussion_r1795564357


##########
shenyu-common/src/main/java/org/apache/shenyu/common/dto/convert/selector/GrpcUpstream.java:
##########
@@ -45,6 +45,7 @@ private GrpcUpstream(final Builder builder) {
         this.weight = builder.weight;
         setStatus(statusValue);
         setTimestamp(builder.timestamp);
+        setNamespaceId(builder.namespaceId);

Review Comment:
   
![image](https://github.com/user-attachments/assets/13f4c9be-319b-4a64-8407-629f103d0635)
   From the functional point of view of the code does not need this at the 
moment.   But it's not wrong from an integrity point of view



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org