moremind commented on code in PR #5692:
URL: https://github.com/apache/shenyu/pull/5692#discussion_r1816736181
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/AlertReceiverController.java:
##########
@@ -76,37 +76,46 @@ public ShenyuAdminResult editReceiver(@Valid @RequestBody
final AlertReceiverDTO
/**
* delete alert receiver.
*
- * @param ids primary key.
+ * @param batchNamespaceCommonDTO batchNamespaceCommonDTO.
* @return result
*/
@DeleteMapping("/batch")
- public ShenyuAdminResult deleteReceiver(@RequestBody @NotEmpty final
List<@NotBlank String> ids) {
- alertReceiverService.deleteReceiver(ids);
+ public ShenyuAdminResult deleteReceiver(@Valid @RequestBody final
BatchNamespaceCommonDTO batchNamespaceCommonDTO) {
+
alertReceiverService.deleteReceiverByNamespaceId(batchNamespaceCommonDTO.getIds(),
batchNamespaceCommonDTO.getNamespaceId());
return ShenyuAdminResult.success(ShenyuResultMessage.DELETE_SUCCESS);
}
/**
* delete alert receiver.
*
* @param id alertReceiver ID
+ * @param namespaceId namespaceId.
* @return result
*/
- @GetMapping("/{id}")
- public ShenyuAdminResult getReceiverDetail(@PathVariable("id") final
String id) {
- AlertReceiverDTO receiverDTO = alertReceiverService.detail(id);
+ @GetMapping("/{id}/{namespaceId}")
+ public ShenyuAdminResult getReceiverDetail(@PathVariable("id") final
String id,
+ @PathVariable("namespaceId")
@Valid
Review Comment:
the blank is error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
