yu199195 commented on code in PR #5845:
URL: https://github.com/apache/shenyu/pull/5845#discussion_r1879844459
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/SelectorServiceImpl.java:
##########
@@ -294,12 +294,14 @@ private void unbindDiscovery(final List<SelectorDO>
selectors, final List<Plugin
if (Objects.nonNull(discoveryDO)) {
final DiscoveryProcessor discoveryProcessor =
discoveryProcessorHolder.chooseProcessor(discoveryDO.getType());
ProxySelectorDTO proxySelectorDTO = new ProxySelectorDTO();
+ proxySelectorDTO.setId(selector.getId());
proxySelectorDTO.setName(selector.getName());
-
proxySelectorDTO.setPluginName(pluginMap.getOrDefault(selector.getId(), ""));
+
proxySelectorDTO.setPluginName(pluginMap.getOrDefault(selector.getPluginId(),
""));
Review Comment:
thanks, great job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
