po-168 commented on code in PR #5874: URL: https://github.com/apache/shenyu/pull/5874#discussion_r1900658999
########## shenyu-sdk/shenyu-sdk-spring/src/main/java/org/apache/shenyu/sdk/spring/ShenyuClientsRegistrar.java: ########## @@ -198,17 +200,17 @@ private String getContextId(final ConfigurableBeanFactory beanFactory, final Map } private String resolve(final ConfigurableBeanFactory beanFactory, final String value) { - if (StringUtils.hasText(value)) { - if (beanFactory == null) { + if (StringUtils.isNotEmpty(value)) { Review Comment: Ok, thank you for your guidance, I will revise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org