Wweiei commented on code in PR #5953:
URL: https://github.com/apache/shenyu/pull/5953#discussion_r2062574132
##########
shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-dubbo/shenyu-plugin-apache-dubbo/src/main/java/org/apache/shenyu/plugin/apache/dubbo/cache/ApacheDubboConfigCache.java:
##########
@@ -274,6 +376,120 @@ private ReferenceConfig<GenericService>
buildReference(final MetaData metaData,
return reference;
}
+ /**
+ * buildReference param with dubboUpstream.
+ *
+ * @param metaData metaData
+ * @param ruleData ruleData
+ * @param namespace namespace
+ * @param dubboUpstream dubboUpstream
+ * @return the reference config
+ */
+ private ReferenceConfig<GenericService> buildReference(final MetaData
metaData, final RuleData ruleData, final String namespace, final DubboUpstream
dubboUpstream) {
+ if (Objects.isNull(dubboUpstream)) {
+ return this.buildReference(metaData, namespace);
+ }
+
+ ReferenceConfig<GenericService> reference = new ReferenceConfig<>();
+ reference.setGeneric("true");
Review Comment:
If it set to "true", it means the generic invocation function is
enabled.Otherwise, when initializing ReferenceConfig<GenericService>, the
caller still needs to hold the Class object of the service interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
