Copilot commented on code in PR #6065:
URL: https://github.com/apache/shenyu/pull/6065#discussion_r2232950787
##########
shenyu-plugin/shenyu-plugin-ai/shenyu-plugin-ai-token-limiter/pom.xml:
##########
@@ -29,21 +29,9 @@
<dependencies>
<dependency>
<groupId>org.apache.shenyu</groupId>
- <artifactId>shenyu-plugin-ai-common</artifactId>
+ <artifactId>shenyu-infra-redis</artifactId>
Review Comment:
The dependency on `shenyu-plugin-ai-common` was removed but
`shenyu-infra-redis` was added. If the AI token limiter plugin requires
functionality from `shenyu-plugin-ai-common`, this dependency should be
retained alongside the new infra dependency.
##########
shenyu-infra/shenyu-infra-redis/pom.xml:
##########
@@ -17,11 +17,35 @@
-->
<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
<parent>
<groupId>org.apache.shenyu</groupId>
<artifactId>shenyu-infra</artifactId>
<version>2.7.0.2-SNAPSHOT</version>
</parent>
+
<modelVersion>4.0.0</modelVersion>
<artifactId>shenyu-infra-redis</artifactId>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.shenyu</groupId>
+ <artifactId>shenyu-plugin-ai-common</artifactId>
Review Comment:
The infrastructure module should not depend on plugin-specific modules like
`shenyu-plugin-ai-common`. This creates a circular dependency where the AI
plugin depends on infra, and infra depends on AI common. Infrastructure modules
should only contain shared utilities without plugin-specific dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
