zhangshenghang opened a new pull request, #6093:
URL: https://github.com/apache/shenyu/pull/6093

   The roundRobinLoadBalanceTest method only calls the methods but contains no 
assertions, making it an ineffective test.
   
   **Fix:Add proper assertions to verify**
   
   - Selected upstream is not null
   - Selected upstream is from the provided list
   - Round-robin distribution behavior with equal weights
   
   <!--
   Thank you for proposing a pull request. This template will guide you through 
the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution 
guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your 
changes.
   - [ ] Your local test passed `./mvnw clean install 
-Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to