Copilot commented on code in PR #6289:
URL: https://github.com/apache/shenyu/pull/6289#discussion_r2768622497
##########
shenyu-plugin/shenyu-plugin-mcp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/transport/ShenyuStreamableHttpServerTransportProvider.java:
##########
@@ -76,6 +77,14 @@ public class ShenyuStreamableHttpServerTransportProvider
implements McpServerTra
*/
private static final String DEFAULT_PROTOCOL_VERSION = "2025-03-26";
+ /**
+ * Supported MCP protocol versions.
+ */
+ private static final java.util.Set<String> SUPPORTED_PROTOCOL_VERSIONS =
java.util.Set.of(
+ DEFAULT_PROTOCOL_VERSION,
+ "2025-11-25"
Review Comment:
The protocol version "2025-11-25" appears suspicious. The MCP specification
typically uses the date format YYYY-MM-DD, and the widely-known MCP protocol
version is "2024-11-05". Please verify that "2025-11-25" is a valid MCP
protocol version supported by the mcp-sdk version 0.17.0. If this is a typo, it
should be corrected to "2024-11-05".
```suggestion
"2024-11-05"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
