Aias00 commented on code in PR #6296:
URL: https://github.com/apache/shenyu/pull/6296#discussion_r2791646675
##########
shenyu-plugin/shenyu-plugin-ai/shenyu-plugin-ai-request-transformer/src/main/java/org/apache/shenyu/plugin/ai/transformer/request/AiRequestTransformerPlugin.java:
##########
@@ -115,15 +116,17 @@ protected Mono<Void> doExecute(final ServerWebExchange
exchange, final ShenyuPlu
AiRequestTransformerTemplate aiRequestTransformerTemplate = new
AiRequestTransformerTemplate(aiRequestTransformerConfig.getContent(),
exchange.getRequest());
ChatClient finalClient = client;
+
return aiRequestTransformerTemplate.assembleMessage()
- .flatMap(message -> Mono.fromCallable(() ->
finalClient.prompt().user(message).call().content())
- .subscribeOn(Schedulers.boundedElastic())
+ .flatMap(message ->
finalClient.prompt().user(message).stream().content()
+ .collectList()
+ .map(list -> String.join("", list))
Review Comment:
No null check on list. If stream returns empty or contains null elements,
this will throw NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
