This is an automated email from the ASF dual-hosted git repository.
moremind pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git
The following commit(s) were added to refs/heads/master by this push:
new 73a4a06811 fix: correct instanceof check in addFailureUriDataRegister
(#6345)
73a4a06811 is described below
commit 73a4a06811e3ed1325a7e1af91a2247b12ee2b8b
Author: eye-gu <[email protected]>
AuthorDate: Sat May 16 23:02:20 2026 +0800
fix: correct instanceof check in addFailureUriDataRegister (#6345)
* fix: correct instanceof check in addFailureUriDataRegister
* ci: trigger CI re-run for flaky k8s-ingress-grpc test
---
.../shenyu/register/client/api/FailbackRegistryRepository.java | 2 +-
.../shenyu/register/client/api/FailbackRegistryRepositoryTest.java | 6 +-----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git
a/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/main/java/org/apache/shenyu/register/client/api/FailbackRegistryRepository.java
b/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/main/java/org/apache/shenyu/register/client/api/FailbackRegistryRepository.java
index a197bc5183..47cdbb355d 100644
---
a/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/main/java/org/apache/shenyu/register/client/api/FailbackRegistryRepository.java
+++
b/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/main/java/org/apache/shenyu/register/client/api/FailbackRegistryRepository.java
@@ -135,7 +135,7 @@ public abstract class FailbackRegistryRepository implements
ShenyuClientRegister
* @param t the t
*/
protected <T> void addFailureUriDataRegister(final T t) {
- if (t instanceof ApiDocRegisterDTO) {
+ if (t instanceof URIRegisterDTO) {
URIRegisterDTO dto = (URIRegisterDTO) t;
String address = String.join(":", dto.getHost(),
String.valueOf(dto.getPort()), dto.getRpcType());
addToFail(new Holder(t, address, Constants.URI));
diff --git
a/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/test/java/org/apache/shenyu/register/client/api/FailbackRegistryRepositoryTest.java
b/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/test/java/org/apache/shenyu/register/client/api/FailbackRegistryRepositoryTest.java
index b4761e8f9b..4126ba00ae 100644
---
a/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/test/java/org/apache/shenyu/register/client/api/FailbackRegistryRepositoryTest.java
+++
b/shenyu-register-center/shenyu-register-client/shenyu-register-client-api/src/test/java/org/apache/shenyu/register/client/api/FailbackRegistryRepositoryTest.java
@@ -86,11 +86,7 @@ public final class FailbackRegistryRepositoryTest {
repository.persistURI(registerDTO);
verify(repository, times(1)).doPersistURI(registerDTO);
- /*
- * The original code has a bug where it checks for ApiDocRegisterDTO
instead of URIRegisterDTO
- * So the failure won't be added to the map
- */
- assertEquals(0, getFailureMapSize());
+ assertEquals(1, getFailureMapSize());
}
@Test