Copilot commented on code in PR #6343:
URL: https://github.com/apache/shenyu/pull/6343#discussion_r3252984951
##########
shenyu-plugin/shenyu-plugin-ai/shenyu-plugin-ai-prompt/src/test/java/org/apache/shenyu/plugin/ai/prompt/AiPromptPluginTest.java:
##########
@@ -50,4 +54,141 @@ void testGetOrder() {
assertEquals(PluginEnum.AI_PROMPT.getCode(), plugin.getOrder());
}
+
+ @Test
+ void testDecorateBodyReturnsOriginalWhenNoMessages() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ String body = "{\"model\":\"gpt-4\"}";
+ String result = invokeDecorateBody(body, config);
+ assertEquals(body, result);
+ }
+
+ @Test
+ void testDecorateBodyReturnsOriginalWhenMessagesEmpty() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ String body = "{\"messages\":[]}";
+ String result = invokeDecorateBody(body, config);
+ assertEquals(body, result);
+ }
+
+ @Test
+ void testDecorateBodyWithPrependAndAppend() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ config.setPrepend("system instruction");
+ config.setPreRole("system");
+ config.setAppend("post instruction");
+ config.setPostRole("assistant");
+
+ String body =
"{\"messages\":[{\"role\":\"user\",\"content\":\"hello\"}]}";
+ String result = invokeDecorateBody(body, config);
+
+ Map<String, Object> resultMap =
GsonUtils.getInstance().convertToMap(result);
+ List<Map<String, Object>> messages = (List<Map<String, Object>>)
resultMap.get("messages");
+
+ assertEquals(3, messages.size());
+ assertEquals("system instruction", messages.get(0).get("content"));
+ assertEquals("system", messages.get(0).get("role"));
+ assertEquals("hello", messages.get(1).get("content"));
+ assertEquals("user", messages.get(1).get("role"));
+ assertEquals("post instruction", messages.get(2).get("content"));
+ assertEquals("assistant", messages.get(2).get("role"));
+ }
+
+ @Test
+ void testDecorateBodyWithOnlyPrepend() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ config.setPrepend("system instruction");
+ config.setPreRole("system");
+
+ String body =
"{\"messages\":[{\"role\":\"user\",\"content\":\"hello\"}]}";
+ String result = invokeDecorateBody(body, config);
+
+ Map<String, Object> resultMap =
GsonUtils.getInstance().convertToMap(result);
+ List<Map<String, Object>> messages = (List<Map<String, Object>>)
resultMap.get("messages");
+
+ assertEquals(2, messages.size());
+ assertEquals("system instruction", messages.get(0).get("content"));
+ assertEquals("hello", messages.get(1).get("content"));
+ }
+
+ @Test
+ void testDecorateBodyPreservesAllOriginalMessages() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ config.setPrepend("system prompt");
+ config.setPreRole("system");
+ config.setAppend("footer");
+ config.setPostRole("assistant");
+
+ String body = "{\"messages\":["
+ + "{\"role\":\"system\",\"content\":\"sys\"},"
+ + "{\"role\":\"user\",\"content\":\"hi\"},"
+ + "{\"role\":\"assistant\",\"content\":\"hello\"},"
+ + "{\"role\":\"user\",\"content\":\"how are you\"}"
+ + "]}";
+ String result = invokeDecorateBody(body, config);
+
+ Map<String, Object> resultMap =
GsonUtils.getInstance().convertToMap(result);
+ List<Map<String, Object>> messages = (List<Map<String, Object>>)
resultMap.get("messages");
+
+ assertEquals(6, messages.size());
+ assertEquals("system prompt", messages.get(0).get("content"));
+ assertEquals("sys", messages.get(1).get("content"));
+ assertEquals("hi", messages.get(2).get("content"));
+ assertEquals("hello", messages.get(3).get("content"));
+ assertEquals("how are you", messages.get(4).get("content"));
+ assertEquals("footer", messages.get(5).get("content"));
+ }
+
+ @Test
+ void testDecorateBodyNoPrependOrAppend() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+
+ String body =
"{\"messages\":[{\"role\":\"user\",\"content\":\"hello\"}]}";
+ String result = invokeDecorateBody(body, config);
+
+ Map<String, Object> resultMap =
GsonUtils.getInstance().convertToMap(result);
+ List<Map<String, Object>> messages = (List<Map<String, Object>>)
resultMap.get("messages");
+
+ assertEquals(1, messages.size());
+ assertEquals("hello", messages.get(0).get("content"));
+ }
+
+ @Test
+ void testDecorateBodyPrependWithoutRoleIgnored() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ config.setPrepend("system instruction");
+
+ String body =
"{\"messages\":[{\"role\":\"user\",\"content\":\"hello\"}]}";
+ String result = invokeDecorateBody(body, config);
+
+ Map<String, Object> resultMap =
GsonUtils.getInstance().convertToMap(result);
+ List<Map<String, Object>> messages = (List<Map<String, Object>>)
resultMap.get("messages");
+
+ assertEquals(1, messages.size());
+ assertEquals("hello", messages.get(0).get("content"));
+ }
+
+ @Test
+ void testDecorateBodyPreservesOtherFields() throws Exception {
+ AiPromptConfig config = new AiPromptConfig();
+ config.setPrepend("prefix");
+ config.setPreRole("system");
+
+ String body =
"{\"model\":\"gpt-4\",\"temperature\":0.7,\"messages\":[{\"role\":\"user\",\"content\":\"hi\"}]}";
+ String result = invokeDecorateBody(body, config);
+
+ Map<String, Object> resultMap =
GsonUtils.getInstance().convertToMap(result);
+ assertEquals("gpt-4", resultMap.get("model"));
+ assertEquals(0.7, ((Number)
resultMap.get("temperature")).doubleValue(), 0.001);
+
+ List<Map<String, Object>> messages = (List<Map<String, Object>>)
resultMap.get("messages");
+ assertEquals(2, messages.size());
+ }
+
+ @SuppressWarnings("unchecked")
+ private String invokeDecorateBody(final String body, final AiPromptConfig
config) throws Exception {
+ Method method = AiPromptPlugin.class.getDeclaredMethod("decorateBody",
String.class, AiPromptConfig.class);
+ method.setAccessible(true);
+ return (String) method.invoke(plugin, body, config);
+ }
Review Comment:
`@SuppressWarnings("unchecked")` on `invokeDecorateBody` doesn't suppress
any unchecked operations in that method (the unchecked casts are in the test
bodies). Consider removing this suppression or moving it to the specific
lines/methods that actually perform unchecked casts to avoid masking real
warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
