eye-gu commented on code in PR #6341:
URL: https://github.com/apache/shenyu/pull/6341#discussion_r3254513423
##########
shenyu-plugin/shenyu-plugin-ai/shenyu-plugin-ai-common/src/main/java/org/apache/shenyu/plugin/ai/common/config/AiCommonConfig.java:
##########
@@ -50,7 +50,7 @@ public class AiCommonConfig {
/**
* temperature.
*/
- private Double temperature = 0.8;
+ private Double temperature;
Review Comment:
The default temperature is intentionally removed (set to null). This is
necessary for the override semantics: when fallbackConfig.getTemperature() is
null, the adapter does not overwrite the client's temperature value. A non-null
default (e.g. 0.8) would always override the client, contradicting the intended
behavior — admin config should only override when explicitly set. Additionally,
temperature has been deprecated or discouraged by several major LLM providers
(e.g. OpenAI recommends using top_p instead), so defaulting to a non-null value
may produce unexpected results with newer models that no longer honor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
