Copilot commented on code in PR #6376:
URL: https://github.com/apache/shenyu/pull/6376#discussion_r3377695708
##########
shenyu-plugin/shenyu-plugin-request/src/main/java/org/apache/shenyu/plugin/request/RequestPlugin.java:
##########
@@ -123,10 +123,10 @@ private void setHeaders(final HttpHeaders headers, final
ServerHttpRequest reque
return;
}
if (MapUtils.isNotEmpty(shenyuReqHeader.getAddHeaders())) {
- shenyuReqHeader.getAddHeaders().entrySet().forEach(s ->
this.fillHeader(s, headers));
+ shenyuReqHeader.getAddHeaders().entrySet().forEach(s ->
this.addHeader(s, headers));
}
if (MapUtils.isNotEmpty(shenyuReqHeader.getSetHeaders())) {
- shenyuReqHeader.getSetHeaders().entrySet().forEach(s ->
this.fillHeader(s, headers));
+ shenyuReqHeader.getSetHeaders().entrySet().forEach(s ->
this.setHeader(s, headers));
}
Review Comment:
The PR title/description focus on stabilizing Sentinel integrated tests, but
this file also changes RequestPlugin behavior ("add" now truly appends headers
instead of overwriting). Please update the PR description/title to reflect this
functional change, or split it into a separate PR so reviewers can assess
behavior changes independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
