Copilot commented on code in PR #6387:
URL: https://github.com/apache/shenyu/pull/6387#discussion_r3419036627
##########
shenyu-dist/shenyu-bootstrap-dist/src/main/release-docs/LICENSE:
##########
@@ -631,6 +631,31 @@ The text of each license is the standard Apache 2.0
license.
javatuples 1.2:
https://mvnrepository.com/artifact/org.javatuples/javatuples, Apache 2.0
jna-platform 5.16.0: https://github.com/java-native-access/jna, Apache 2.0
+ lz4-java 1.10.1: https://github.com/yawkat/lz4-java, Apache 2.0
+ itu 1.14.0: https://github.com/ethlo/itu, Apache 2.0
+ jsonschema-generator 4.38.0:
https://github.com/victools/jsonschema-generator, The Apache License, Version
2.0
+ jsonschema-module-jackson 4.38.0:
https://github.com/victools/jsonschema-generator, The Apache License, Version
2.0
+ jsonschema-module-swagger-2 4.38.0:
https://github.com/victools/jsonschema-generator, The Apache License, Version
2.0
+ re2j 1.8: https://github.com/google/re2j, Go License
Review Comment:
This entry appears to misclassify both the license name and the license
grouping. `re2j` is BSD-licensed (commonly BSD 3-Clause), not an Apache 2.0
dependency, so listing it under the Apache 2.0 section as 'Go License' is
likely incorrect for release compliance. Move it under the BSD licenses section
and use an explicit BSD label (e.g., 'BSD 3-Clause').
##########
shenyu-dist/shenyu-bootstrap-dist/src/main/release-docs/LICENSE:
##########
@@ -631,6 +631,31 @@ The text of each license is the standard Apache 2.0
license.
javatuples 1.2:
https://mvnrepository.com/artifact/org.javatuples/javatuples, Apache 2.0
jna-platform 5.16.0: https://github.com/java-native-access/jna, Apache 2.0
+ lz4-java 1.10.1: https://github.com/yawkat/lz4-java, Apache 2.0
+ itu 1.14.0: https://github.com/ethlo/itu, Apache 2.0
+ jsonschema-generator 4.38.0:
https://github.com/victools/jsonschema-generator, The Apache License, Version
2.0
+ jsonschema-module-jackson 4.38.0:
https://github.com/victools/jsonschema-generator, The Apache License, Version
2.0
+ jsonschema-module-swagger-2 4.38.0:
https://github.com/victools/jsonschema-generator, The Apache License, Version
2.0
+ re2j 1.8: https://github.com/google/re2j, Go License
+ json-schema-validator 2.0.0:
https://github.com/networknt/json-schema-validator, Apache License Version 2.0
Review Comment:
License strings are inconsistent within the same section ('The Apache
License, Version 2.0' vs 'Apache License Version 2.0' vs elsewhere 'Apache
2.0'). To keep the generated/maintained release LICENSE easy to audit,
standardize these new entries to match the existing convention in this file
(e.g., 'Apache 2.0').
##########
shenyu-dist/shenyu-bootstrap-dist/src/main/release-docs/LICENSE:
##########
@@ -631,6 +631,31 @@ The text of each license is the standard Apache 2.0
license.
javatuples 1.2:
https://mvnrepository.com/artifact/org.javatuples/javatuples, Apache 2.0
jna-platform 5.16.0: https://github.com/java-native-access/jna, Apache 2.0
+ lz4-java 1.10.1: https://github.com/yawkat/lz4-java, Apache 2.0
Review Comment:
The PR description is still the default template and doesn’t explain what
license gaps are being fixed or why these specific dependencies were added.
Please update the description to briefly state what changed (e.g., which
modules introduced these dependencies) and how you verified the
dependency/license list.
##########
shenyu-dist/shenyu-bootstrap-dist/src/main/release-docs/LICENSE:
##########
@@ -631,6 +631,31 @@ The text of each license is the standard Apache 2.0
license.
javatuples 1.2:
https://mvnrepository.com/artifact/org.javatuples/javatuples, Apache 2.0
jna-platform 5.16.0: https://github.com/java-native-access/jna, Apache 2.0
+ lz4-java 1.10.1: https://github.com/yawkat/lz4-java, Apache 2.0
Review Comment:
The project URL for `lz4-java` looks like a fork rather than the canonical
upstream repository. For accurate attribution in release docs, point to the
official upstream project URL used by the artifact publisher (commonly
`https://github.com/lz4/lz4-java`).
##########
shenyu-dist/shenyu-admin-dist/src/main/release-docs/LICENSE:
##########
@@ -577,6 +579,7 @@ The text of each license is also included at
licenses/LICENSE-[project].txt.
checker-qual 3.33.0: https://checkerframework.org/, MIT
jopt-simple 5.0.4: https://github.com/jopt-simple/jopt-simple, MIT
oshi-core 6.10.0: https://github.com/oshi/oshi, MIT
+ oshi-core 6.7.0: https://github.com/oshi/oshi, MIT
Review Comment:
This adds a second `oshi-core` entry alongside an existing `oshi-core
6.10.0` entry. If both versions are truly shipped, consider adding a short note
or keeping a consistent ordering/grouping (e.g., sorted by name then version)
to make audits easier; otherwise, remove the older/unused version to avoid
ambiguity in the release inventory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
