Copilot commented on code in PR #589:
URL: https://github.com/apache/shenyu-dashboard/pull/589#discussion_r3489320762
##########
src/services/api.js:
##########
@@ -547,8 +547,13 @@ export async function queryPlatform() {
/* login */
export async function queryLogin(params) {
- return request(`${baseUrl}/platform/login?${stringify(params)}`, {
- method: `GET`,
+ return request(`${baseUrl}/platform/login`, {
+ method: `POST`,
+ body: {
+ userName: params.userName,
+ password: params.password,
+ clientId: params.clientId,
+ },
Review Comment:
`queryLogin` no longer forwards `verifyCode`, but the login UI conditionally
collects it (when `needCode` is true) and previously it would have been
included via `stringify(params)`. This will likely break logins that require a
verification code/captcha. Also consider defaulting `params` to `{}` to avoid
runtime errors if it is ever called without an argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
