Aias00 commented on code in PR #6411:
URL: https://github.com/apache/shenyu/pull/6411#discussion_r3524584721
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/SwaggerImportController.java:
##########
@@ -53,17 +55,22 @@ public SwaggerImportController(final SwaggerImportService
swaggerImportService)
* @return the result of swagger import
*/
@PostMapping("/import")
- public ShenyuAdminResult importSwagger(@Valid @RequestBody final
SwaggerImportRequest request) {
+ public ResponseEntity<ShenyuAdminResult> importSwagger(@Valid @RequestBody
final SwaggerImportRequest request) {
Review Comment:
why change response type?
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/SwaggerImportController.java:
##########
@@ -74,14 +81,19 @@ public ShenyuAdminResult importSwagger(@Valid @RequestBody
final SwaggerImportRe
* @return the result of config import
*/
@PostMapping("import/mcp")
- public ShenyuAdminResult importMcpConfig(@Valid @RequestBody final
SwaggerImportRequest request) {
+ public ResponseEntity<ShenyuAdminResult> importMcpConfig(@Valid
@RequestBody final SwaggerImportRequest request) {
Review Comment:
why change response type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
