Aias00 opened a new issue, #6552:
URL: https://github.com/apache/shenyu/issues/6552

   ## Description
   `update` is not annotated `@Transactional`. It calls `updateSubTags(tagDTO)` 
which loads all tags, rebuilds the `ext` chain, and recursively calls 
`tagMapper.updateByPrimaryKey(tagDO)` for every descendant, *then* updates the 
parent itself. If the parent update (or any descendant update) fails, the 
descendants that already succeeded are left with `ext` values computed from the 
new parent while the parent row still holds the old values — a torn tree.
   
   ## Location
   ```
   shenyu-admin/.../service/impl/TagServiceImpl.java:86-92 (recursion at 
:156-193)
   ```
   
   ## Impact
   Sub-tree `ext` metadata becomes inconsistent with the parent; some children 
updated, parent/others not, with no rollback.
   
   ## Suggested fix
   Annotate `update` with `@Transactional(rollbackFor = Exception.class)`.
   
   ## Related existing issue(s)
   #6520 is a different NPE on missing `parentTagId`; not a dup.
   
   _Identified during the 2026-08-02 audit; full list in 
[`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to