Aias00 opened a new issue, #6594:
URL: https://github.com/apache/shenyu/issues/6594

   ## Description
   `try { sendHeartbeatMethod.invoke(...); } catch (Exception e) { 
assertTrue(e.getCause() instanceof RuntimeException); }` — no `fail()` after 
the invoke. If the regression that should make `sendHeartbeat` throw is fixed 
(or silently starts succeeding), the catch is never entered and the test passes 
vacuously.
   
   ## Location
   ```
   
shenyu-register-center/shenyu-register-client-beat/src/test/java/org/apache/shenyu/register/client/beat/HeartbeatListenerTest.java:185-192
   ```
   
   ## Impact
   The "login failure -> RuntimeException" contract is unenforced.
   
   ## Suggested fix
   `assertThrows(InvocationTargetException.class, …)` and assert on cause type.
   
   ## Related existing issue(s)
   None
   
   _Identified during the 2026-08-02 audit; full list in 
[`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to