Aias00 commented on issue #6467: URL: https://github.com/apache/shenyu/issues/6467#issuecomment-5157897807
Follow-up verification note (2026-08-02 audit) — severity/accuracy clarification. The buffering of non-binary request bodies is **intentional**: `WebClientPlugin.java:79-83` streams byte-type bodies (`outputMessage.writeWith(body)`) but joins everything else via `DataBufferUtils.join(body)`, with the inline comment "fix chinese garbled code". So the buffering itself is a deliberate tradeoff, not a bug. The genuine defect here is narrower and worth keeping the issue for: the no-arg `DataBufferUtils.join(body)` enforces **no size limit** — `shenyu.httpclient.maxInMemorySize` is not applied on this path. A large non-binary request body is fully buffered into heap with no cap, which is a real memory exposure under the `webClient` strategy (the `netty` strategy streams via `nettyOutbound.send`). Suggested reframing: keep the issue open but scope it to "apply `maxInMemorySize` to the `DataBufferUtils.join(body)` path" rather than "stop buffering non-binary bodies". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
