Aias00 opened a new issue, #6680:
URL: https://github.com/apache/shenyu/issues/6680
- severity: High; files:
`shenyu-integrated-test/shenyu-integrated-test-{apache-dubbo,combination,grpc,http,https,rewrite,sdk-apache-dubbo,sdk-http,sofa,spring-cloud,websocket}/script/healthcheck.sh`
(verified: `grep -c exit` = 0 in all of them)
- description: Each script loops `for loop in seq 1 30` and `break`s on HTTP
200, but after the loop it only does `sleep 3; echo` and returns. There is NO
`exit 1` on failure. The CI step "Wait for docker compose start up completely"
(`integrated-test.yml:158-159`, calls `bash .../healthcheck.sh`) ALWAYS
succeeds. Unhealthy/never-started services proceed to the "Run test" step,
producing misleading downstream test failures instead of a clear "services did
not start" failure. (Contrast: the shared
`shenyu-integrated-test/k8s-ingress-healthcheck.sh` correctly does `set -euo
pipefail` + `exit "${failed}"`; the k8s-ingress-* per-module scripts delegate
to it.)
- impact: CI masks real startup failures across ~11 test matrices; wasted
debug time; false confidence.
- suggested_fix: Track a `failed=0` flag, set it when the 30-try loop
exhausts without 200, and `exit "${failed}"` at the end (mirror
`k8s-ingress-healthcheck.sh`).
- confidence: High
---
_Identified during the 2026-08-02 deep re-scan; full list in
[`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
