Aias00 commented on PR #6406:
URL: https://github.com/apache/shenyu/pull/6406#issuecomment-5193464194
Correct fix — the cache hit path was being clobbered. Previously
`selectorData = defaultMatchSelector(...)` ran unconditionally, so even when
the match-data cache returned a non-null `selectorData`, it was immediately
overwritten by a fresh default-match pass (and same for `ruleData`). The double
null-gate (`if (isNull) { defaultMatch; if (isNull) handleIfNull; }`) means the
cache result is now respected and the expensive match only runs on a cache
miss. Behavior for the null/no-cache path is unchanged.
Minor: the diff also carries a lot of trailing-whitespace / param-alignment
churn. Harmless, just makes the substantive ~8-line change harder to spot in
review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
