nikhiln64 commented on issue #6884: URL: https://github.com/apache/shenyu/issues/6884#issuecomment-5225122781
I would like to take this one. A heads up on the batch first, the issue bodies filed on Aug 4 appear to be offset by one from their titles. The description matching this title actually sits in the body of #6883, this issue's body describes the keep alive unit bug titled in #6885, and the pattern continues through the batch. Might be worth realigning them so future readers land on the right analysis. On the bug itself, confirmed in code. For byte type media appendResponse calls logResponse with a null writer, so when the response also has no Content-Length header responseContentLength is never set. desensitizeShenyuRequestLog then calls toString on it unconditionally and throws. status can stay null the same way because appendResponse only sets it when the status code is already committed, and upstreamResponseTime is nullable on the same class of paths. I have a fix with null guards on the three boxed fields plus a regression test, opening the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
