Aias00 commented on PR #6915: URL: https://github.com/apache/shenyu/pull/6915#issuecomment-5289028177
Optional, non-blocking nits Since the project targets Java 17, bos.toString(StandardCharsets.UTF_8.name()) (throws checked UnsupportedEncodingException) could be simplified to bos.toString(StandardCharsets.UTF_8) — pre-existing code, fine to leave. ByteArrayOutputStream.close() is a no-op, so strictly only gis needs managing — keeping both in the try-with-resources is harmless and arguably clearer, so no change needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
