yykaue opened a new pull request, #6931:
URL: https://github.com/apache/shenyu/pull/6931
## What this PR does
Closes #6814.
The version-specific sign providers and parameter extractors previously had
no direct test coverage. Their behavior was only exercised indirectly through
the default provider, extractor, and sign service tests.
This PR adds direct tests for:
- `VersionOneSignProvider`
- Signing without a request body.
- Signing with request body and query parameters.
- Handling an empty request body.
- Excluding an untrusted `sign` parameter from signature generation.
- `VersionTwoSignProvider`
- Signing relative URLs with query parameters.
- Signing requests with an optional body.
- `VersionOneExtractor`
- Extracting complete v1 sign headers.
- Handling missing headers.
- `VersionTwoExtractor`
- Preferring `ShenYu-Authorization`.
- Falling back to the standard `Authorization` header.
- Handling missing tokens.
- Handling tokens without a signature separator.
No production code is changed.
## Verification
- 12 new tests pass.
- 16 relevant new and existing tests pass.
- All four target classes reach 100% instruction, branch, line, and method
coverage.
- Compilation and Checkstyle pass.
@Aias00 Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
