sunnysabor commented on PR #6968:
URL: https://github.com/apache/shenyu/pull/6968#issuecomment-5379547670
### Future Discussion
This PR intentionally keeps the scope small and only preserves the existing
discovery `props` extension channel as runtime `Upstream.metadata`.
There may be a broader question about whether ShenYu should support full
registry instance metadata passthrough in the future. In many production
environments, service-level information such as `az`, `version`, `grayTag`,
`zone`, or custom routing labels is usually stored directly in registry
instance
metadata rather than being packed into a single `props` field.
Currently, registry implementations such as Eureka and Nacos only extract a
small set of known fields plus the `props` entry. This keeps the discovery
model
stable, but it may also make custom routing and gray release scenarios
harder to
integrate because users need to repack existing metadata into `props`.
It would be helpful to understand the community's view on this design:
whether ShenYu intends to keep `props` as the only generic extension
channel, or
whether a full metadata passthrough model could be supported in a future
change.
A full metadata passthrough would likely require a larger design discussion
because it may affect registry adapters, `DiscoveryUpstreamData`, admin
storage,
sync data, and runtime upstream conversion. Therefore it is not included
in this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
