juicewcode opened a new pull request, #6973:
URL: https://github.com/apache/shenyu/pull/6973
Fixes #6623
`ScaleRuleServiceImpl#create` and `update` build `ScaleRuleDO` twice.
For create operations without an ID, each call to `buildScaleRuleDO`
generates a new UUID. Therefore, the entity stored
in the cache may have a different ID from the entity inserted into the
database.
For update operations, rebuilding the entity can also produce a different
`dateUpdated` timestamp.
## Changes
- Reuse the original `ScaleRuleDO` after a successful create.
- Reuse the `after` entity after a successful update.
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through
the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your
changes.
- [x] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
