wy471x commented on PR #6983: URL: https://github.com/apache/shenyu/pull/6983#issuecomment-5467130091
> Correction to my previous review comment, where inline code formatting was stripped by my local shell: > > The duplicate-CONNECT path looks like it needs cleanup before closing the channel. A successful first CONNECT registers the channel in `ChannelRepository`, but this new early return only calls `ctx.close()`. I only see repository cleanup in the explicit DISCONNECT flow, and there does not appear to be centralized `channelInactive` cleanup for MQTT channels, so a client that sends CONNECT twice can leave a closed channel referenced in `ChannelRepository`. Could you remove the channel from `ChannelRepository` before closing here, or add centralized channel-inactive cleanup for all server/client close paths? These issues has been fixed! Please take a look when you hava time, thank you! @Aias00 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
