dmsolr opened a new pull request, #7015:
URL: https://github.com/apache/shenyu/pull/7015

   ### What is the purpose of the change
   
   Fixes #6873.
   
   `BaseResultMap` in `instance-info-sqlmap.xml` mapped 
id/date_created/date_updated/instance_ip/instance_port/instance_type/instance_info/namespace_id
 but not `instance_state`, even though `Base_Column_List` includes 
`instance_state` and `insert`/`updateById` write it. Every resultMap-based 
SELECT (`selectAll`, `findAllByNamespaceId`, `selectByQuery`) returned 
`instanceState = null` for rows with a non-null state. 
(`selectById`/`selectOneByQuery` use `resultType` auto-mapping and were 
unaffected.) This is the upstream root cause of the `InstanceCheckService` 
null-state autoboxing NPEs referenced in #6706.
   
   `Base_Column_List` also listed `date_created`/`date_updated` twice — a 
copy-paste defect.
   
   ### Changes
   - Added `<result column="instance_state" jdbcType="INTEGER" 
property="instanceState"/>` to `BaseResultMap`.
   - Removed the duplicate `date_created`/`date_updated` entries from 
`Base_Column_List`.
   - Extended `InstanceInfoMapperTest` (`selectAll`, `findAllByNamespaceId`, 
`selectByQuery`) to assert `instanceState` round-trips correctly through the 
resultMap-based queries.
   
   ### Does this PR introduce a user-facing change?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to