juicewcode opened a new pull request, #7052:
URL: https://github.com/apache/shenyu/pull/7052
Fixes #6706
## Summary
- Prevent `InstanceCheckService` from throwing NPE when an instance has a
null state.
- Normalize null states to the default state code when loading instance
data.
- Replace unsafe autounboxing comparisons with `Objects.equals`.
- Filter null states before `Collectors.groupingBy` in state statistics
and visualization.
- Change `InstanceInfoVO.instanceState` to `Integer` so null database
values can be represented safely.
- Preserve `instanceState` and `lastHeartBeatTime` when mapping
`InstanceInfoDO` to `InstanceInfoVO`.
## Test
- Added coverage for normalizing null instance states during data loading.
- Added coverage for visualization when an instance has a null state.
- Added coverage ensuring scheduled `doCheck` does not throw for null
states.
- Existing instance state, namespace filtering, pie chart, and history
data tests remain covered.
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through
the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your
changes.
- [x] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
