Copilot commented on code in PR #7074:
URL: https://github.com/apache/shenyu/pull/7074#discussion_r4032852110
##########
shenyu-plugin/shenyu-plugin-logging/shenyu-plugin-logging-common/src/main/java/org/apache/shenyu/plugin/logging/common/body/LoggingServerHttpResponse.java:
##########
@@ -83,18 +82,18 @@ public class LoggingServerHttpResponse<L extends
ShenyuRequestLog> extends Serve
* @param logInfo access log
* @param logCollector LogCollector instance
* @param desensitized desensitize flag
- * @param keyWordSet user keyWord set
+ * @param keyWordMatch compiled keyword matcher
* @param dataDesensitizeAlg desensitize function
*/
public LoggingServerHttpResponse(final ServerHttpResponse delegate, final
L logInfo,
final LogCollector<L> logCollector, final
boolean desensitized,
- final Set<String> keyWordSet, final
String dataDesensitizeAlg) {
+ final KeyWordMatch keyWordMatch, final
String dataDesensitizeAlg) {
Review Comment:
Changing this public constructor from `Set<String>` to `KeyWordMatch` is
source- and binary-incompatible for consumers of
`shenyu-plugin-logging-common`. Keep the matcher-taking constructor for the
optimized internal path, but retain the previous signature as a delegating
overload so existing integrations continue to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
