dengliming opened a new issue, #632:
URL: https://github.com/apache/shenyu-dashboard/issues/632

   ## Description
   `exportConfigClick` passes a `callback` that closes the modal, but 
`common/exportByNamespace` never invokes any callback (it just awaits 
`asyncConfigExportByNamespace`). For import, `common/import` calls `callback()` 
with no argument when `json.data === null`, and the header's callback then does 
`JSON.parse(res)` with `res === undefined`, throwing a `SyntaxError` inside the 
saga (modal never closes, loading stuck).
   
   ## Location
   (Lines refer to `master @ 83969a5`.)
   - `src/components/GlobalHeader/index.js:184-192` (import callback)
   - `src/components/GlobalHeader/index.js:225-239` (export callback)
   - `src/models/common.js:260-279`
   
   ## Impact
   Export: the file downloads but the ExportModal stays open until Cancel. 
Import: when the backend reports success with no detail, the UI throws instead 
of closing the modal.
   
   ## Suggested fix
   Invoke `callback()` after the export completes; in the import callback guard 
`res` before parsing (`if (res) showImportRestlt(JSON.parse(res))`).
   
   ## Related existing
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to