dengliming opened a new issue, #640:
URL: https://github.com/apache/shenyu-dashboard/issues/640

   ## Description
   `fetch` uses `response.data` / `response.total` without checking `code`, and 
`add`/`update`/`delete` treat any truthy response as success (`if (response)`), 
so a `{ code: 500, message }` body shows a success toast and triggers a reload.
   
   ## Location
   (Lines refer to `master @ 83969a5`.)
   - `src/models/mcpServer.js:22-60`
   
   ## Impact
   Currently only `mcpServer/swaggerImport` is dispatched from routes, so the 
impact is latent, but any future use of these effects will report failures as 
successes.
   
   ## Suggested fix
   Check `response.code === 200` like the other models and show 
`response.message` otherwise.
   
   ## Related existing
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to