sunnysabor opened a new pull request, #7270: URL: https://github.com/apache/shenyu/pull/7270
Fixes #7169 When a watched Nacos instance changes only its weight or metadata, the registry currently emits ADDED and DELETED as well as UPDATED. The spurious deletion can remove the live upstream before the update is applied. Use the same instance-identity comparison for all three event types: compare nonblank instance IDs, falling back to IP, port and cluster when an ID is unavailable. Attribute changes now emit only UPDATED; actual additions and removals retain their existing events. Regression tests exercise the public watch callback with weight changes (including null/empty IDs), metadata changes, unchanged instances, normal additions/removals, and distinct IPs, ports and clusters without IDs. Validation: - Before the fix, the regression run failed in four cases. - Passed: `./mvnw -s /tmp/shenyu-maven-central-settings.xml -pl shenyu-registry/shenyu-registry-nacos -am test` — 452 tests, 0 failures/errors, 1 existing skipped test; all 11 Nacos tests passed. Checkstyle passed. - Passed: `git diff --check`. - Full `clean install -Dmaven.javadoc.skip=true` is running locally; the result will be updated here. The temporary settings file only selects Maven Central for this environment. - [x] Read the contribution guidelines. - [x] Added regression tests for the changed behavior. - [ ] Local full build passed `./mvnw clean install -Dmaven.javadoc.skip=true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
