dustinCodes84600 commented on PR #7162: URL: https://github.com/apache/shenyu/pull/7162#issuecomment-5832961213
`testFixedConnectionPoolUsesBoundedPendingQueue` only proves we don't call `pendingAcquireMaxCount`; it doesn't prove queue is bounded. Since release notes promise exactly 2x `maxConnections`, might be safer to set that explicitly or add an integration-level assertion against the built provider so a Reactor Netty default change doesn't silently break the guarantee. fwiw, made a visual walkthrough while reading, covering the pool default change: https://flyovers.dev/flyover/e44a0c7a-f35f-481d-8be4-4296837c4ad3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
