This is an automated email from the ASF dual-hosted git repository.
Aias00 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git
The following commit(s) were added to refs/heads/master by this push:
new ad3e423ede [type:fix] page the mock request record list query in the
database (#6808) (#7215)
ad3e423ede is described below
commit ad3e423ede3457bab2ee913f3d95e0b0933a9414
Author: HY-love-sleep <[email protected]>
AuthorDate: Sat Sep 26 12:53:28 2026 +0800
[type:fix] page the mock request record list query in the database (#6808)
(#7215)
Co-authored-by: aias00 <[email protected]>
---
.../admin/service/impl/MockRequestRecordServiceImpl.java | 2 ++
.../shenyu/admin/service/MockRequestRecordServiceTest.java | 11 +++++++++++
2 files changed, 13 insertions(+)
diff --git
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MockRequestRecordServiceImpl.java
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MockRequestRecordServiceImpl.java
index 57e4cb58df..c53d87a10b 100644
---
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MockRequestRecordServiceImpl.java
+++
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MockRequestRecordServiceImpl.java
@@ -18,6 +18,7 @@
package org.apache.shenyu.admin.service.impl;
import org.apache.commons.lang3.StringUtils;
+import org.apache.shenyu.admin.aspect.annotation.Pageable;
import org.apache.shenyu.admin.mapper.MockRequestRecordMapper;
import org.apache.shenyu.admin.model.dto.MockRequestRecordDTO;
import org.apache.shenyu.admin.model.entity.MockRequestRecordDO;
@@ -79,6 +80,7 @@ public class MockRequestRecordServiceImpl implements
MockRequestRecordService {
return
MockRequestRecordVO.buildMockRequestRecordVO(mockRequestRecordDO);
}
+ @Pageable
@Override
public CommonPager<MockRequestRecordVO> listByPage(final
MockRequestRecordQuery mockRequestRecordQuery) {
List<MockRequestRecordDO> list =
mockRequestRecordMapper.selectByQuery(mockRequestRecordQuery);
diff --git
a/shenyu-admin/src/test/java/org/apache/shenyu/admin/service/MockRequestRecordServiceTest.java
b/shenyu-admin/src/test/java/org/apache/shenyu/admin/service/MockRequestRecordServiceTest.java
index 2c3eae9f33..c37bfa2979 100644
---
a/shenyu-admin/src/test/java/org/apache/shenyu/admin/service/MockRequestRecordServiceTest.java
+++
b/shenyu-admin/src/test/java/org/apache/shenyu/admin/service/MockRequestRecordServiceTest.java
@@ -18,9 +18,11 @@
package org.apache.shenyu.admin.service;
import com.google.common.collect.Lists;
+import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
+import org.apache.shenyu.admin.aspect.annotation.Pageable;
import org.apache.shenyu.admin.mapper.MockRequestRecordMapper;
import org.apache.shenyu.admin.model.dto.MockRequestRecordDTO;
import org.apache.shenyu.admin.model.entity.MockRequestRecordDO;
@@ -37,6 +39,7 @@ import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.BDDMockito.given;
@@ -98,6 +101,14 @@ public class MockRequestRecordServiceTest {
assertEquals(1, cnt);
}
+ @Test
+ public void testListByPageIsPageable() throws NoSuchMethodException {
+ // without @Pageable the whole mock_request_record table (every TEXT
body included) is read
+ // into memory and shipped to the client, so the annotation is what
keeps the query paged
+ Method listByPage =
MockRequestRecordServiceImpl.class.getDeclaredMethod("listByPage",
MockRequestRecordQuery.class);
+ assertTrue(listByPage.isAnnotationPresent(Pageable.class));
+ }
+
private MockRequestRecordDTO buildMockRequestRecordDTO() {
MockRequestRecordDTO mockRequestRecordDTO = new MockRequestRecordDTO();
mockRequestRecordDTO.setApiId("1");