Mukezh commented on code in PR #661:
URL: https://github.com/apache/shenyu-dashboard/pull/661#discussion_r4112231756
##########
src/models/common.js:
##########
@@ -258,7 +258,11 @@ export default {
},
*exportByNamespace(params, { call }) {
+ const { callback } = params;
yield call(asyncConfigExportByNamespace, params);
+ if (callback) {
+ callback();
Review Comment:
Addressed, thank you for identifying this,
Export now closes the modal only after a verified ZIP download. HTTP errors
and HTTP 200 Admin error responses are surfaced without invoking the success
callback. Added test coverage for the mentioned status codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
