lymerin commented on code in PR #7289:
URL: https://github.com/apache/shenyu/pull/7289#discussion_r4114668247
##########
shenyu-admin-listener/shenyu-admin-listener-api/src/main/java/org/apache/shenyu/admin/listener/AbstractPathDataChangedListener.java:
##########
@@ -97,6 +98,10 @@ public void onProxySelectorChanged(final
List<ProxySelectorData> changed, final
@Override
public void onDiscoveryUpstreamChanged(final List<DiscoverySyncData>
changed, final DataEventTypeEnum eventType) {
for (DiscoverySyncData data : changed) {
+ if (StringUtils.isBlank(data.getPluginName())) {
Review Comment:
Thanks for the suggestion. I extended the guard to reject blank `selectorId`
values as well as blank plugin names, and added `namespaceId` to the warning.
Tests now cover a missing selector ID on DELETE and a blank selector ID on
UPDATE. The focused listener tests pass (5/5). This is included in `7f49de8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
