sunnysabor commented on issue #6833: URL: https://github.com/apache/shenyu/issues/6833#issuecomment-5940631937
I checked the current upstream implementation at `09c6a528` against the remaining lifetime concern in this issue. `sessions` and `sessionTransports` are `ConcurrentHashMap`s, and `ShenyuMcpExchangeHolder.EXCHANGE_MAP` is also a `ConcurrentHashMap`; there is no TTL or expiry sweep. Entries are removed on explicit `removeSession`/transport close and cleared on graceful shutdown. PR #6997 addresses the initialize-path key mismatch so explicit close can remove its entry, but a client that initializes a session and never sends DELETE/closes it can still retain all three map entries indefinitely. Please keep this expiry/lifetime concern visible as a separate follow-up or acceptance item if #6997 is merged, rather than treating the full issue as resolved by the key-alignment change alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
