sunnysabor commented on PR #7344: URL: https://github.com/apache/shenyu/pull/7344#issuecomment-5942804065
Additional reproduction for the failure-budget concern at this head (`cca4e49b`): in a detached worktree I temporarily added a test that models three full-sync attempts, each with sequence 0 successfully applying and sequence 1 throwing for the same poison payload. I expected only the first two attempts to close and the third to reach the configured cap/backoff. The focused command ```text ./mvnw -B -ntp -pl shenyu-sync-data-center/shenyu-sync-data-websocket -am -Dtest=ShenyuWebsocketClientTest -DfailIfNoTests=false -Djacoco.skip=true -Dmaven.javadoc.skip=true test ``` ran 31 tests with 30 passing and the temporary assertion failing: `close()` was called 3 times instead of 2. Each sequence-0 success resets `consecutiveSyncFailures` at `ShenyuWebsocketClient.java:464` before the poison frame fails, so the count stays at 1 across reconnects and never reaches the cap. I removed the temporary test afterward. Could the failure budget be reset only once the complete initial snapshot is successfully applied (or otherwise track snapshot-level failures), while retaining the per-message reset for post-sync incremental updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
