sunnysabor commented on PR #7406: URL: https://github.com/apache/shenyu/pull/7406#issuecomment-5945427382
Addressed in signed-off commit `fe42651e5`. The periodic executor remains active after the latch opens, so `releaseMaster()` is now verified with `atLeast(2)` just like `selectMaster()`; later scheduled ticks can no longer make the test fail on an exact call count. I also aligned the wrapper with the `Exception` handling convention used in the related instance-sync fix. Validation passed on the rebased current `upstream/master` base: `./mvnw -B -ntp -pl shenyu-admin -am -Dtest=ShenyuClusterServiceTest -Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true -Dmaven.javadoc.skip=true -Drat.skip=true test` The target test passed (1 test), the 38-module dependency reactor completed, Checkstyle reported 0 violations, and `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
