Sean-Walker0 commented on PR #7418: URL: https://github.com/apache/shenyu/pull/7418#issuecomment-6005600360
Addressed the review: a `replaceHeaderKeys` entry whose target key equals the source key (exact or case-only, and `HttpHeaders` is case-insensitive) is now a no-op instead of deleting the header. - `testReplaceHeaderKeysSameKeyIsNoOp` and `testReplaceHeaderKeysCaseOnlyRenameIsNoOp` were both red on the previous head (`expected: <[abc]> but was: <null>` — the header was dropped) and pass on this commit. - Full module suite: `./mvnw -pl shenyu-plugin/shenyu-plugin-modify-response -am test -B` — 15/15 green, checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
