lymerin opened a new pull request, #7435: URL: https://github.com/apache/shenyu/pull/7435
Fixes #6527 `EtcdInstanceRegisterRepository.selectInstances()` creates a persistent watcher without retaining its handle. The watcher updates an internal cache, but subsequent selections query etcd directly instead of returning cached instances. This PR removes that watcher and the unused `watcherInstanceRegisterMap`. Each selection continues to query etcd and preserve the existing JSON conversion and URI handling. Explicit subscriptions through `watchInstances()` and their cleanup through `unWatchInstances()` and `close()` remain unchanged. Regression tests cover: - First and repeated selections without creating watchers. - Fresh results after instance additions, updates, and deletions, including URI handling. - Explicit watcher notifications and cleanup. The watcher regression test fails against the previous implementation. All 9 module tests pass with this fix, along with Checkstyle and Apache RAT. Make sure that: - [x] You have read the [[contribution guidelines](https://shenyu.apache.org/community/contributor-guide)](https://shenyu.apache.org/community/contributor-guide). - [x] You submit test cases (unit or integration tests) that back your changes. - [x] Your local module verification passed `.\mvnw.cmd -B -o -pl shenyu-registry/shenyu-registry-etcd verify -Dmaven.javadoc.skip=true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
