Aias00 opened a new issue, #7479:
URL: https://github.com/apache/shenyu/issues/7479
## Description
`e2e-websocket-sync-compose.sh` starts the WebSocket example compose file:
-
`shenyu-e2e/shenyu-e2e-case/shenyu-e2e-case-websocket/compose/script/e2e-websocket-sync-compose.sh:39`
and the normal cleanup path stops the same WebSocket compose file:
-
`shenyu-e2e/shenyu-e2e-case/shenyu-e2e-case-websocket/compose/script/e2e-websocket-sync-compose.sh:61`
But the failure diagnostics branch prints a Dubbo label and reads logs from
a Dubbo compose file:
-
`shenyu-e2e/shenyu-e2e-case/shenyu-e2e-case-websocket/compose/script/e2e-websocket-sync-compose.sh:55`
-
`shenyu-e2e/shenyu-e2e-case/shenyu-e2e-case-websocket/compose/script/e2e-websocket-sync-compose.sh:57`
`shenyu-examples-dubbo-compose.yml` does not exist in the WebSocket compose
directory. The only example compose file there is
`shenyu-examples-websocket-compose.yml`.
## Impact
Passing WebSocket E2E runs are unaffected. When the WebSocket E2E test
fails, the diagnostic branch cannot collect the example service logs and emits
an unrelated compose-file error instead. That makes CI failures harder to debug
and can hide the original failure context.
## Suggested fix
Use the WebSocket compose file and label in the failure branch:
```sh
echo "shenyu-examples-websocket log:"
docker compose -f "${PRGDIR}"/shenyu-examples-websocket-compose.yml logs
shenyu-examples-websocket
```
## Related existing issues
No duplicate was found in the supplied issue/PR baselines. Closed #6681
covered storage E2E script path/healthcheck issues, not this WebSocket
failure-logging branch.
## Reviewed Revision And Validation
Apache ShenYu 2.7.2-SNAPSHOT, master at
a89b6a2338c24e978428b731e8f1edce86022418. Severity: low. Confidence: high.
Two reviews checked the failure branch, the actual present WebSocket compose
file and the absent referenced Dubbo file; shell syntax was checked.
Current source references:
-
`shenyu-e2e/shenyu-e2e-case/shenyu-e2e-case-websocket/compose/script/e2e-websocket-sync-compose.sh:55`
-
`shenyu-e2e/shenyu-e2e-case/shenyu-e2e-case-websocket/compose/script/e2e-websocket-sync-compose.sh:57`
No implementation fix or full deployed end-to-end validation was performed
by this review. Source-flow and runtime evidence are distinguished above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
