lymerin commented on PR #7482: URL: https://github.com/apache/shenyu/pull/7482#issuecomment-6051290950
> Reviewed current head `844b120ee3f4`. > > The queue offer policy fix is source-correct, and exact-head ShenyuThreadPoolExecutorTest passed. > > Validation: exact-head targeted Maven reactor tests passed on Java 17. > > ```shell > ./mvnw -pl shenyu-common -am test -Dtest=ShenyuThreadPoolExecutorTest -Dsurefire.failIfNoSpecifiedTests=false -Drat.skip=true -Djacoco.skip=true -DskipRemoteResources=true -Dmaven.javadoc.skip=true > ``` > > GitHub still reports failing checks: [e2e](https://github.com/apache/shenyu/actions/runs/37668539489/job/112970780260), [e2e-case (e2e-logging-rabbitmq-compose, shenyu-e2e-case-logging-rabbitmq, :shenyu-examples-http)](https://github.com/apache/shenyu/actions/runs/37668539489/job/112960744476). This review does not claim those checks have passed. Thanks for the review. The failure came from a RabbitMQ E2E synchronization race, unrelated to this queue fix. Following the current plan to defer CI changes , we retriggered the checks with a comment-only update (`5d1244b7551a`). [RabbitMQ E2E](https://github.com/apache/shenyu/actions/runs/37718286915/job/113121004838) and the [E2E summary](https://github.com/apache/shenyu/actions/runs/37718286915/job/113124100513) now pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
