yangjj-iso commented on PR #7551: URL: https://github.com/apache/shenyu/pull/7551#issuecomment-6136164494
Thanks for the review. I checked the schema for the suggested `dataType` extension: MySQL's `plugin_id_field_type` unique index is exactly `(plugin_id, field, type)`; the PostgreSQL index also uses those three columns. `data_type` is not part of that identity. Adding it to the import key would allow an insert that violates the MySQL constraint, so the current `(field, type)` key within the remapped plugin is intentional. The existing regression tests cover exact-key duplicates, differing types and successful-insert tracking; no additional code change is needed for this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
