Aias00 opened a new issue, #7588:
URL: https://github.com/apache/shenyu/issues/7588

   ## Summary
   
   `shenyu-infra-common` is **not declared in `shenyu-infra/pom.xml`'s 
`<modules>`**, even though three sibling modules under `shenyu-infra` depend on 
it.
   
   It is only reachable because the **root** `pom.xml` declares it directly:
   
   ```xml
   <!-- pom.xml:50-51 -->
   <module>shenyu-infra</module>
   <module>shenyu-infra/shenyu-infra-common</module>
   ```
   
   ```xml
   <!-- shenyu-infra/pom.xml:30-33 -->
   <module>shenyu-infra-etcd</module>
   <module>shenyu-infra-nacos</module>
   <module>shenyu-infra-redis</module>
   <module>shenyu-infra-zookeeper</module>
   ```
   
   ## Evidence
   
   `shenyu-infra-common` is depended on by three modules whose parent is 
`shenyu-infra`:
   
   - `shenyu-infra/shenyu-infra-etcd/pom.xml:32`
   - `shenyu-infra/shenyu-infra-nacos/pom.xml`
   - `shenyu-infra/shenyu-infra-zookeeper/pom.xml`
   
   ```xml
   <dependency>
       <groupId>org.apache.shenyu</groupId>
       <artifactId>shenyu-infra-common</artifactId>
       <version>${project.version}</version>
   </dependency>
   ```
   
   Because it is absent from the parent aggregator, any build that resolves 
`shenyu-infra` as the reactor root — for example:
   
   ```
   mvn -pl shenyu-infra -am clean install
   cd shenyu-infra && mvn clean install
   ```
   
   fails to resolve `shenyu-infra-common` unless it was already installed into 
the local repository by a previous full-reactor build. Downstream consumers who 
vendor or partially build `shenyu-infra` hit the same wall.
   
   ## Impact
   
   - Aggregator/child-module inconsistency: the root pom and the `shenyu-infra` 
pom disagree about what the reactor contains.
   - Partial builds of `shenyu-infra` are not self-contained.
   - The full root-reactor build masks the problem, so CI never reports it.
   
   ## Suggested fix
   
   Add the missing entry to `shenyu-infra/pom.xml`:
   
   ```xml
   <modules>
       <module>shenyu-infra-common</module>
       <module>shenyu-infra-etcd</module>
       <module>shenyu-infra-nacos</module>
       <module>shenyu-infra-redis</module>
       <module>shenyu-infra-zookeeper</module>
   </modules>
   ```
   
   and drop the now-redundant 
`<module>shenyu-infra/shenyu-infra-common</module>` from the root `pom.xml` 
(keeping the root `<module>shenyu-infra</module>` is enough — the child 
aggregator will pull it in).
   
   ## Environment
   
   - Branch: `master` @ `a7d80b7`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to