HY-love-sleep commented on issue #7623: URL: https://github.com/apache/shenyu/issues/7623#issuecomment-6163043697
@Aias00 I have opened this as a design-first issue rather than a PR, so the behaviour and the extension point can be agreed before I generate the admin registration rows. Context: this is the same area as the merged `ai-sensitive-word` (#7153 / #7155) that you reviewed, so I would value your direction on the six proposals under *Open questions for maintainers*. The ones that actually change the code shape are: - the `PluginEnum` code — take `196` as-is, or renumber so the cheap dictionary check (197) runs before this judge; - the default failure policy when the judge is unreachable, and the denial status for a recognized AI protocol; - whether circuit breaking belongs in v1, or the plugin ships with `timeout` + `failClosed` only and reuses the existing Resilience4j dependency later; - where the AI protocol extraction profiles live while #7382 is in flight (I propose this module, with a follow-up if a shared hook appears). I would rather cut the scope down to something you consider reviewable than arrive with a large PR — tell me which parts to drop and I will scope the first PR to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
