marDC-it commented on issue #654:
URL:
https://github.com/apache/shenyu-dashboard/issues/654#issuecomment-6188043761
Hi - I'd like to take this one.
A data point for the open question in the issue ("verify that the roadhog
build
works on Node 22/24 without --openssl-legacy-provider"):
On Node v24.21.0 (Windows) the full local check set passes, with no
NODE_OPTIONS flag and
no other workaround:
| command | result |
| --- | --- |
| `npm ci` | 3562 packages, no errors |
| `npm run build` | `Compiled successfully` in 85s |
| `npm run test:coverage` | 56 suites / 281 tests passed |
| `npm run lint` | 0 errors (3 eslint warnings; stylelint runs at
`defaultSeverity: warning`) |
So roadhog does not need the legacy OpenSSL provider on Node 24, and the
matrix
can move to [22.x, 24.x] without a build workaround. I have not tested Node
22
locally — the proposed matrix covers it in CI.
One thing I noticed in build.yml while checking this: the lint step is gated
on
`if: matrix.node-version == '20.x'`. If the matrix changes without that
condition
being updated, lint would silently stop running. I'll handle it in the same
PR.
I'll open a PR covering engines, .nvmrc, the README prerequisite and the
three
workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
