bhaskargurram-ai commented on code in PR #718:
URL: https://github.com/apache/shenyu-dashboard/pull/718#discussion_r4294535265
##########
src/routes/System/NamespacePlugin/AddModal.js:
##########
@@ -139,25 +152,45 @@ class AddModal extends Component {
/>,
)}
</FormItem>
- {data && data.length > 0 && (
+ {configError && (
+ <FormItem
+ label={getIntlContent("SHENYU.COMMON.SETTING")}
+ {...formItemLayout}
+ >
+ {getFieldDecorator("config", {
+ initialValue: config,
+ rules: [
+ {
+ validator: (rule, value, callback) =>
+ callback(
+ parseJsonObject(value).error
Review Comment:
Fixed in c40a67f: the field now has to parse as a JSON object, so clearing
it no longer passes, and each form has a clear-then-save test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
