Aias00 commented on code in PR #7682: URL: https://github.com/apache/shenyu/pull/7682#discussion_r4300790250
########## shenyu-plugin/shenyu-plugin-httpclient/src/test/resources/META-INF/shenyu/org.apache.shenyu.plugin.api.tracing.TraceContextPropagator: ########## @@ -0,0 +1,18 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +http=org.apache.shenyu.plugin.httpclient.TestTraceContextPropagator Review Comment: [note] Registering the stub propagator in the module test resources activates trace-context injection for every test in shenyu-plugin-httpclient, not just the trace tests (the static propagator field in AbstractHttpClientPlugin picks it up module-wide). CI is green so nothing regresses, but worth knowing: any future test in this module that asserts the exact set of outgoing headers will now see an injected traceparent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
